Rust: Attribute-style procedural macro to generate EVMC FFI code with user-defined data

[jakelang]

Closes #168.
Closes #223.
Part of #308.

[axic]

Need to add the new creates into .bumpversion.cfg

[axic]

Can you order the builder helpers the same way they ordered in evmc_declare_vm?

[jakelang]

It is not macro-parameterized, so we can just stick the entire thing in evmc-vm's lib.rs.

…

On Tue, May 7, 2019, 20:21 Alex Beregszaszi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In bindings/rust/evmc-declare/src/lib.rs <#262 (comment)>: > + let static_version_ident = Ident::new(&concatenated_version, name_allcaps.span()); + + // Turn the stylized VM name and version into string literals. + // FIXME: Not sure if the span of name.as_str() is the same as that of name. + let stylized_name_literal = LitStr::new(name_stylized.as_str(), name_stylized.as_str().span()); + let version_literal = LitStr::new(version, version.span()); + + quote! { + static #static_name_ident: &'static str = #stylized_name_literal; + static #static_version_ident: &'static str = #version_literal; + } +} + +/// Generates a definition and impl for a struct which contains the EVMC instance needed by FFI, +/// and the user-defined VM. +// TODO: Move this struct and impl into evmc_vm. How would you do that? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#262 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYRBBZBIEPNGN6FK3WLFUTPUIMJJANCNFSM4HKXUJHQ> .

[jakelang]

I switched back in order to get this done more quickly. To do the field manipulation (i had this done in earlier commits), we also need to be able to properly initialize arbitrary fields in evmc_create_vm

…

On Tue, May 7, 2019, 20:21 Alex Beregszaszi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In bindings/rust/evmc-declare/src/lib.rs <#262 (comment)>: > + let version_literal = LitStr::new(version, version.span()); + + quote! { + static #static_name_ident: &'static str = #stylized_name_literal; + static #static_version_ident: &'static str = #version_literal; + } +} + +/// Generates a definition and impl for a struct which contains the EVMC instance needed by FFI, +/// and the user-defined VM. +// TODO: Move this struct and impl into evmc_vm. +fn build_vm_container() -> proc_macro2::TokenStream { + quote! { + struct __EvmcContainer<T: ::evmc_vm::EvmcVm + Sized> { + instance: ::evmc_sys::evmc_instance, + vm: T, So we're still doing the same trick here 😉 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#262 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYRBBYBEWFMT2TPPMYMYXLPUIMG3ANCNFSM4HKXUJHQ> .

[axic]

Also we need to change the examplevm to use this in order to test it.

[axic]

Need to rebase.

rebased

[axic]

Please rebase.

[axic]

NOTE: Removed the evmc_sys as ffi alias. May reintroduce later if I make a workaround.

Why? Can it be done in a separate PR then?

[axic]

Have you tested that the bumpversion config works?

[jakelang]

Have you tested that the bumpversion config works?

How do I test this?

Rebased again

[axic]

Since this is a comprehensive test, I'd say we need to VMs declared here:

1. supports single capability and takes version from crate
2. supports multiple capabilities and takes version from declare macro