Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify validity of result::create_address #276

Merged
merged 2 commits into from
May 9, 2019
Merged

docs: Clarify validity of result::create_address #276

merged 2 commits into from
May 9, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented May 9, 2019

No description provided.

@chfast chfast requested a review from axic May 9, 2019 10:57
@chfast chfast force-pushed the vmtester-create-address branch from 3df719e to a6e7336 Compare May 9, 2019 11:05
axic
axic requested changes May 9, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually can we enforce that VMs return 0 for address?

@chfast chfast force-pushed the vmtester-create-address branch from a6e7336 to 811648d Compare May 9, 2019 11:17
@chfast chfast force-pushed the vmtester-create-address branch from 811648d to 3779b53 Compare May 9, 2019 11:21
@chfast chfast merged commit 5946e11 into master May 9, 2019
@chfast chfast deleted the vmtester-create-address branch May 9, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic