Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: allow empty code in evmc_execute() #346

Merged
merged 1 commit into from
Jul 4, 2019
Merged

rust: allow empty code in evmc_execute() #346

merged 1 commit into from
Jul 4, 2019

Conversation

axic
Copy link
Member

@axic axic commented Jul 4, 2019 •
edited
Loading

Conforms (mostly) to #345. Precompiles capability is not properly supported as context is required and would mean a bigger refactoring.

Part of #318.

@axic axic requested a review from jakelang July 4, 2019 12:43
@axic axic force-pushed the rust-declare branch 2 times, most recently from 1dabd40 to b82021c Compare July 4, 2019 15:58
@axic axic merged commit cab1073 into master Jul 4, 2019
@axic axic deleted the rust-declare branch July 4, 2019 17:08
jakelang
jakelang reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelang jakelang jakelang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @jakelang