-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support London EIP-3198: BASEFEE opcode #603
Conversation
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 95.68% 95.70% +0.01%
==========================================
Files 24 24
Lines 3941 3954 +13
==========================================
+ Hits 3771 3784 +13
Misses 170 170 |
13a0a9f
to
b5c002e
Compare
bindings/go/evmc/host.go
Outdated
@@ -76,6 +76,7 @@ type TxContext struct { | |||
GasLimit int64 | |||
Difficulty Hash | |||
ChainID Hash | |||
BaseFee Hash // EIP-1559, EIP-3198 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep these comments here? If so, perhaps for the older ones (such as ChainID) too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
* EIP-3198: BASEFEE opcode * Preliminary support for London consensus tests * Revert to upstream evmc as ethereum/evmc/pull/603 is merged now * Switch back to upstream evmone as ethereum/evmone/pull/333 is merged
Necessary facilities for EIP-3198, which is included into London hard fork.