loader: Do not repeat strlen(options) condition #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 24 24
Lines 3511 3511
Branches 358 358
=======================================
Hits 3260 3260
Misses 144 144
Partials 107 107 |
gumb0
reviewed
Dec 27, 2021
| { | ||
| ec = set_error(EVMC_LOADER_INVALID_OPTION_NAME, "%s (%s) does not support any options", | ||
| vm->name, path); | ||
| goto exit; |
There was a problem hiding this comment.
Could be break; now, but maybe keeping goto is fine for consistency.
There was a problem hiding this comment.
I use goto exit because the later switch is also using it in case of error.
gumb0
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This at least confuses static analyzers.