C++: Do not cache tx context in HostContext #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
+ Coverage 92.79% 92.81% +0.02%
==========================================
Files 24 24
Lines 3537 3533 -4
Branches 363 362 -1
==========================================
- Hits 3282 3279 -3
Misses 146 146
+ Partials 109 108 -1 |
chfast
force-pushed
the
cpp_tx_context_nocache
branch
2 times, most recently
from
d33383e to
112687d
Compare
chfast
force-pushed
the
cpp_tx_context_nocache
branch
from
112687d to
3511043
Compare
yperbasis
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ API for HostContext was caching the tx context. The caching seems good idea, but the EVM might want to do it its own way, but it is inconvenient if it cannot change the behavior here.
So this change is removing this responsibility from C++ API.