C++: Add convenient result constructors #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 93.05% 93.02% -0.03%
==========================================
Files 25 25
Lines 3655 3657 +2
Branches 379 379
==========================================
+ Hits 3401 3402 +1
- Misses 144 145 +1
Partials 110 110 |
yperbasis
approved these changes
Aug 3, 2022
axic
reviewed
Aug 3, 2022
include/evmc/evmc.hpp
Outdated
| /// | ||
| /// @param _status_code The status code. | ||
| /// @param _gas_left The amount of gas left. | ||
| /// @param _create_address The address of the possibly created account. This can be valid |
There was a problem hiding this comment.
How is the address valid in creation failure?
axic
reviewed
Aug 5, 2022
| * (evmc_result::status_code is ::EVMC_SUCCESS). | ||
| * The create address may be provided even though the contract creation has failed | ||
| * (evmc_result::status_code is not ::EVMC_SUCCESS). This is useful in situations | ||
| * when the address is observable, e.g. access to it remains warm. |
There was a problem hiding this comment.
Hmm, in what case does the address remain warm?
There was a problem hiding this comment.
In most cases of failing contact creation, but not all. Obviously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New constructors are added based on the usage in state transition implementation in evmone.