Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for EOF creation tx in evmc run #713

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jul 25, 2024

This PR will be accompanied by a PR in evmone, fixing the handling of top level creation msgs when validation EOF.

Here, we only replicate the behavior of creation txs for EOF - if the code begins with EOF magic it will be interpreted as an EOF creation transaction and the msg kind will be set appropriately, in order to be consumed by the vm.execute

@pdobacz pdobacz self-assigned this Jul 25, 2024
@pdobacz pdobacz requested review from chfast, gumb0 and rodiazet July 25, 2024 11:57
@pdobacz pdobacz marked this pull request as ready for review July 25, 2024 12:11
@pdobacz
Copy link
Contributor Author

pdobacz commented Jul 25, 2024

I needed to do two tweaks to the CI for this to work:

  • bump build-macos - not sure what I'm doing here, just best-guess, deprecation announcement here
  • downgrade VS 2022 on appveyor - MSVC 1940 (17.40.x) is failing for a reason beyond my comprehension, using "Previous..." image as I got a hint from some old post puts it back at 17.39.x which worked. I can put in an issue to un-downgrade it lest we forget to

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.41%. Comparing base (0a642bc) to head (874f134).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   93.46%   93.41%   -0.05%     
==========================================
  Files          26       26              
  Lines        3884     3887       +3     
  Branches      402      404       +2     
==========================================
+ Hits         3630     3631       +1     
  Misses        140      140              
- Partials      114      116       +2     

@chfast chfast force-pushed the fix-eof-creation branch from 1d40102 to 874f134 Compare July 26, 2024 10:58
@chfast chfast merged commit 7c0de9d into master Jul 26, 2024
19 checks passed
@chfast chfast deleted the fix-eof-creation branch July 26, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants