-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake minimum version? #63
Comments
Just a bug. I assumed that cmake will ignore policies it does not know. The solution would be to enclose that with version checking code. What a mess.... |
I've just found the canonical solution. I will fix that. |
Fixed here be not included in libethereum. Update the submodule there if you need it know or will come with next update later on. |
Thanks @chfast I changed locally and worked fine! |
The policy CMP0054 was introduced in CMake 3.1. If earlier version of CMake is used this policy should not be set. Fixes #63.
During @programonauta work on getting cpp-ethereum building on Debian 8 (Jesse), he's seeing the following build break:
Google tells me that CMP0054 was introduced in CMake 3.1.
https://cmake.org/cmake/help/v3.1/policy/CMP0054.html
In various parts of our documentation, I have seen our minimum version for CMake listed as 3.0.
Now we could obviously say "Our minimum CMake version is 3.1", but I think this one place is probably the only use we have of a > 3.0 feature, so maybe we can weaken it off, or do something conditional so that we just work out of the box on Debian.
What do you guys think? @chfast, @chriseth?
The text was updated successfully, but these errors were encountered: