Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake minimum version? #63

Closed
bobsummerwill opened this issue Jun 9, 2016 · 4 comments
Closed

CMake minimum version? #63

bobsummerwill opened this issue Jun 9, 2016 · 4 comments
Assignees
Labels

Comments

@bobsummerwill
Copy link
Contributor

During @programonauta work on getting cpp-ethereum building on Debian 8 (Jesse), he's seeing the following build break:

CMake Error at libethereum/evmjit/CMakeLists.txt:5 (cmake_policy):
  Policy "CMP0054" is not known to this version of CMake.

Google tells me that CMP0054 was introduced in CMake 3.1.

https://cmake.org/cmake/help/v3.1/policy/CMP0054.html

In various parts of our documentation, I have seen our minimum version for CMake listed as 3.0.

Now we could obviously say "Our minimum CMake version is 3.1", but I think this one place is probably the only use we have of a > 3.0 feature, so maybe we can weaken it off, or do something conditional so that we just work out of the box on Debian.

What do you guys think? @chfast, @chriseth?

@chfast
Copy link
Member

chfast commented Jun 9, 2016

Just a bug. I assumed that cmake will ignore policies it does not know. The solution would be to enclose that with version checking code. What a mess....

@chfast
Copy link
Member

chfast commented Jun 9, 2016

I've just found the canonical solution. I will fix that.
https://cmake.org/Wiki/CMake/Policies#Supporting_Multiple_CMake_Versions

@chfast
Copy link
Member

chfast commented Jun 9, 2016

Fixed here be not included in libethereum. Update the submodule there if you need it know or will come with next update later on.

@programonauta
Copy link

Thanks @chfast I changed locally and worked fine!

chfast added a commit that referenced this issue Oct 21, 2016
The policy CMP0054 was introduced in CMake 3.1. If earlier version of CMake is used this policy should not be set.

Fixes #63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants