Skip to content

Commit

Permalink
Remove redundant has_full_data() check from TXCREATE
Browse files Browse the repository at this point in the history
The check is now part of validation of toplevel container. For creation transaction this is still required to be checked before validation to find out container/input data split.
  • Loading branch information
gumb0 authored and chfast committed Jun 6, 2024
1 parent 82d9ffe commit d813e73
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/evmone/instructions_calls.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -402,10 +402,6 @@ Result create_eof_impl(
const auto error_subcont = validate_eof(state.rev, initcontainer);
if (error_subcont != EOFValidationError::success)
return {EVMC_SUCCESS, gas_left}; // "Light" failure.

const auto initcontainer_header = read_valid_eof1_header(initcontainer);
if (!initcontainer_header.has_full_data(initcontainer.size()))
return {EVMC_SUCCESS, gas_left}; // "Light" failure.
}

evmc_message msg{.kind = to_call_kind(Op)};
Expand Down

0 comments on commit d813e73

Please sign in to comment.