baseline: VM-level execution states #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
baseline/global_execution_states
branch
from
d702cd1 to
b864d6b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1005 +/- ##
=======================================
Coverage 93.97% 93.98%
=======================================
Files 147 147
Lines 15580 15586 +6
=======================================
+ Hits 14642 14649 +7
+ Misses 938 937 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
baseline/code_api
branch
from
3016caf to
6e2f5d9
Compare
chfast
force-pushed
the
baseline/global_execution_states
branch
from
b864d6b to
8242be7
Compare
battlmonstr
approved these changes
Sep 12, 2024
chfast
force-pushed
the
baseline/global_execution_states
branch
from
8242be7 to
5d35254
Compare
This adds an array of `ExecutionState` objects to the `VM` instance: one lazily initialized object for all possible call depths. This also makes the `VM` non-thread safe, but it is fine for current users. We can improve on this in the future by spiting the the VM into two parts: non-thread safe opaque execution context and a thread-safe VM with user configuration.
Use the new array of `ExecutionState`s from the `VM`. Remove the `ExecutionState` parameter from the Baseline execution API. This removes the need of maintaining an external object pool for execution states.
chfast
force-pushed
the
baseline/global_execution_states
branch
from
5d35254 to
112ff3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an array of
ExecutionStateobjects to theVMinstance. They are used internally in the Baseline interpreter instead of passing one via API. This removes the need of maintaining object pool for execution states.However, this also makes the
VMnon-thread safe, but it is fine for current users. We can improve on this in the future by spiting the the VM into two parts: non-thread safe opaque execution context and a thread-safe VM with user configuration.