Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompiles: Implement BLS pairing check #1016

Merged
merged 1 commit into from
Sep 18, 2024
Merged

precompiles: Implement BLS pairing check #1016

merged 1 commit into from
Sep 18, 2024

Conversation

rodiazet
Copy link
Collaborator

Implementation of the bls12_pairing_check precompile: According to spec https://eips.ethereum.org/EIPS/eip-2537#abi-for-pairing-check

Depends on: #1012

@rodiazet rodiazet added precompiles Related to EVM precompiles Prague Changes for Prague upgrade labels Sep 18, 2024
@rodiazet rodiazet requested a review from chfast September 18, 2024 11:00
@rodiazet rodiazet force-pushed the bls-pairing branch 5 times, most recently from aee4546 to 16983c0 Compare September 18, 2024 12:59
circle.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.18%. Comparing base (f007e7c) to head (7603add).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
test/state/precompiles.cpp 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   94.15%   94.18%   +0.03%     
==========================================
  Files         147      147              
  Lines       15796    15843      +47     
==========================================
+ Hits        14872    14922      +50     
+ Misses        924      921       -3     
Flag Coverage Δ
eof_execution_spec_tests 17.26% <0.00%> (-0.06%) ⬇️
ethereum_tests 27.28% <0.00%> (-0.09%) ⬇️
ethereum_tests_silkpre 19.15% <0.00%> (-0.06%) ⬇️
execution_spec_tests 20.34% <88.23%> (+0.22%) ⬆️
unittests 88.76% <62.74%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone_precompiles/bls.cpp 100.00% <100.00%> (ø)
test/unittests/precompiles_bls_test.cpp 100.00% <100.00%> (ø)
test/state/precompiles.cpp 98.87% <92.85%> (+1.21%) ⬆️

@chfast chfast changed the base branch from master to bls-map-to-point September 18, 2024 13:21
@rodiazet rodiazet force-pushed the bls-map-to-point branch 4 times, most recently from 06af5a5 to dac8d4d Compare September 18, 2024 13:46
@rodiazet rodiazet force-pushed the bls-pairing branch 2 times, most recently from 1b3ce92 to 161eaee Compare September 18, 2024 13:49
Base automatically changed from bls-map-to-point to master September 18, 2024 14:00
Co-authored-by: Paweł Bylica <pawel@ethereum.org>
@chfast chfast enabled auto-merge (squash) September 18, 2024 14:02
@chfast chfast merged commit edfe00d into master Sep 18, 2024
23 checks passed
@chfast chfast deleted the bls-pairing branch September 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prague Changes for Prague upgrade precompiles Related to EVM precompiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants