Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench: Add option to load external EVMC VM #111

Merged
merged 1 commit into from
Jul 25, 2019
Merged

bench: Add option to load external EVMC VM #111

merged 1 commit into from
Jul 25, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Jul 25, 2019 

evmone-bench <evmc_module> <path_to_benchmarks_dir>

@chfast
bench: Add option to load external EVMC VM
eec09fa 
evmone-bench <evmc_module> <path_to_benchmarks_dir>
@chfast chfast requested a review from axic July 25, 2019 12:08
@codecov-io
Copy link

Codecov Report

Merging #111 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #111      +/-   ##
=========================================
- Coverage   93.46%   93.4%   -0.06%     
=========================================
  Files          18      18              
  Lines        1866    1866              
  Branches      197     197              
=========================================
- Hits         1744    1743       -1     
- Misses         97      98       +1     
  Partials       25      25

axic
axic approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chfast
Copy link
Member Author

chfast commented Jul 25, 2019

Looks good to me.

Looks good to me too.

@chfast chfast merged commit 0424654 into master Jul 25, 2019
@chfast chfast deleted the bench_external_vm branch July 25, 2019 12:34
@chfast
Copy link
Member Author

chfast commented Jul 25, 2019

@gumb0 you can also test aleth-interpreter with it.

jwasinger pushed a commit to jwasinger/evmone that referenced this pull request Apr 27, 2021
@chfast
Merge pull request ethereum#111 from ethereum/go-host-type-checks
e119c53 
go: Add Host exported functions type checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @codecov-io @axic