Implement EIP-2200 #142
Implement EIP-2200 #142
Conversation
|
|
||
| // Modified again: | ||
| storage.clear(); | ||
| storage[v1] = {v1, true}; | ||
| execute(sstore(1, push(2))); | ||
| EXPECT_EQ(result.status_code, EVMC_SUCCESS); | ||
| EXPECT_EQ(gas_used, rev == EVMC_CONSTANTINOPLE ? 206 : 5006); |
There was a problem hiding this comment.
Shouldn't all these have >= CONSTANTINOPLE?
E.g. (rev >= istanbul) elseif (rev == constantinople) else .. (because it was disabled in petersburg)
There was a problem hiding this comment.
right, changed now to cover post-Istanbul revisions
... although the loop iterates only till EVMC_ISTANBUL
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 99.88% 99.88% +<.01%
==========================================
Files 5 5
Lines 845 858 +13
Branches 109 113 +4
==========================================
+ Hits 844 857 +13
Misses 1 1 |
|
"OOG if gas below stipend" is not implemented yet |
lib/evmone/instructions.cpp
Outdated
| if (state.rev >= EVMC_ISTANBUL) | ||
| { | ||
| const auto correction = state.current_block_cost - instr->arg.p.number; | ||
| const auto gas_left = static_cast<uint64_t>(state.gas_left + correction); |
There was a problem hiding this comment.
This doesn't seem to work right: for PUSH1 0 PUSH1 0 SSTORE with 2306 starting gas, at the beginning of SSTORE state.gas_left is 2300 and correction is 6
There was a problem hiding this comment.
got it, arg.p.number should be filled for SSTORE in analysis
gumb0
force-pushed
the
eip-2200
branch
2 times, most recently
from
5f2da5b to
6bead9b
Compare
gumb0
force-pushed
the
eip-2200
branch
2 times, most recently
from
0dfe5c9 to
7c65f43
Compare
ethereum/EIPs#2200