-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize build_jumpdest_map() #308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks on Haswell 4.0 GHz, Clang 12.
|
chfast
force-pushed
the
analysis_jumpdest_optimization
branch
from
April 27, 2021 14:04
09711e0
to
e47e240
Compare
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 99.76% 99.76% -0.01%
==========================================
Files 24 24
Lines 3832 3831 -1
==========================================
- Hits 3823 3822 -1
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
Apr 27, 2021
gumb0
reviewed
Apr 27, 2021
gumb0
approved these changes
Apr 27, 2021
Optimize the build_jumpdest_map() procedure by comparing opcode as signed integer and eliminating always true op <= OP_PUSH32 (0x7f) check.
chfast
force-pushed
the
analysis_jumpdest_optimization
branch
from
April 27, 2021 17:24
e47e240
to
96ddad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the build_jumpdest_map() procedure by comparing opcode as
signed integer and eliminating always true op <= OP_PUSH32 (0x7f) check.