Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: Run execution benchmarks with MockedHost #319

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented May 11, 2021

This allows using state-access instructions in benchmarks. Previously
such benchmarks would crash.

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #319 (a7f404f) into master (4a7161b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          24       24           
  Lines        3832     3832           
=======================================
  Hits         3823     3823           
  Misses          9        9           
Flag Coverage Δ
consensus 99.10% <ø> (ø)
unittests 99.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chfast
Copy link
Member Author

chfast commented May 11, 2021

This does not seem to affect timings of current benchmarks.

This allows using state-access instructions in benchmarks. Previously
such benchmarks would crash.
@chfast chfast force-pushed the bench_mocked_host branch from d60d80e to a7f404f Compare May 13, 2021 10:25
@chfast chfast merged commit df7e02b into master May 13, 2021
@chfast chfast deleted the bench_mocked_host branch May 13, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants