Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOF static relative jumps (EIP-4200) #389

Closed
wants to merge 6 commits into from
Closed

EOF static relative jumps (EIP-4200) #389

wants to merge 6 commits into from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 30, 2021

No description provided.

@gumb0 gumb0 changed the base branch from master to eof-code-validation September 30, 2021 19:01
@gumb0 gumb0 mentioned this pull request Sep 30, 2021
Closed
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch from 5e91bc5 to 7af5797 Compare October 4, 2021 11:24
@gumb0 gumb0 force-pushed the eof-code-validation branch from 3b42a85 to 2411d77 Compare October 4, 2021 11:27
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch 6 times, most recently from 67822bf to 3e27a1c Compare October 5, 2021 15:00
@codecov
Copy link

codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #389 (875d04e) into master (6d03f5d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   98.03%   98.09%   +0.06%     
==========================================
  Files          59       59              
  Lines        5687     5880     +193     
==========================================
+ Hits         5575     5768     +193     
  Misses        112      112
Flag Coverage Δ
blockchaintests 75.88% <10.52%> (-2.27%) ⬇️
statetests 71.46% <10.52%> (-1.31%) ⬇️
unittests 91.99% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/advanced_instructions.cpp 100.00% <ø> (ø)
test/unittests/evm_fixture.hpp 100.00% <ø> (ø)
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
lib/evmone/baseline.hpp 100.00% <100.00%> (ø)
lib/evmone/baseline_instruction_table.cpp 100.00% <100.00%> (ø)
lib/evmone/eof.cpp 98.46% <100.00%> (+0.38%) ⬆️
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_eof_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_fixture.cpp 90.90% <100.00%> (+2.02%) ⬆️
... and 2 more

@gumb0 gumb0 force-pushed the eof-static-jumps2 branch 4 times, most recently from 687df04 to 502cdc4 Compare October 6, 2021 15:00
@gumb0 gumb0 force-pushed the eof-code-validation branch from 2411d77 to c950be7 Compare October 6, 2021 15:28
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch 2 times, most recently from f9c19b3 to 6bc9097 Compare October 6, 2021 15:40
@gumb0 gumb0 force-pushed the eof-code-validation branch 3 times, most recently from a73f066 to eb773aa Compare October 11, 2021 16:43
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch from 6bc9097 to ef8e9de Compare October 12, 2021 14:27
@gumb0 gumb0 force-pushed the eof-code-validation branch 2 times, most recently from e68059e to 173f0ab Compare March 9, 2022 11:25
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch 4 times, most recently from 72faad0 to 8c4e530 Compare March 10, 2022 13:09
@gumb0 gumb0 force-pushed the eof-code-validation branch 2 times, most recently from 1210ca1 to e017bda Compare March 16, 2022 11:47
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch from c28ff2a to d673002 Compare April 4, 2022 11:06
Base automatically changed from eof-code-validation to master April 4, 2022 11:07
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch from d673002 to ba0b70b Compare April 4, 2022 11:08
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch from ba0b70b to f9cafab Compare July 28, 2022 10:41
@chfast chfast force-pushed the eof-static-jumps2 branch 3 times, most recently from ccf10d9 to 3da226a Compare September 28, 2022 14:28
@chfast chfast changed the base branch from master to analysis_executable_code September 28, 2022 16:00
@chfast chfast force-pushed the analysis_executable_code branch from 6f8875c to 53305d4 Compare September 30, 2022 09:33
Base automatically changed from analysis_executable_code to master September 30, 2022 12:03
@gumb0 gumb0 mentioned this pull request Nov 10, 2022
Open
axic
axic requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase and support for RJUMPV.

@gumb0 gumb0 force-pushed the eof-static-jumps2 branch 2 times, most recently from 610af5f to 7974e05 Compare December 6, 2022 13:39
@gumb0
Copy link
Member Author

gumb0 commented Dec 6, 2022

Rebased and removed dependency on EVMC update, disabling some tests that check evmc<->evmone instructions correspondence.

@gumb0 gumb0 force-pushed the eof-static-jumps2 branch 2 times, most recently from 3e89dde to 1ab5b19 Compare December 6, 2022 14:10
@gumb0
Copy link
Member Author

gumb0 commented Dec 6, 2022

Made RJUMPs be activated in Shanghai.

@gumb0 gumb0 force-pushed the eof-static-jumps2 branch from 1ab5b19 to 9c49c47 Compare December 7, 2022 16:45
@gumb0 @chfast
Undefine RJUMP* instructions in non-EOF code
875d04e 
Co-authored-by: Paweł Bylica <pawel@hepcolgum.band>
@gumb0 gumb0 force-pushed the eof-static-jumps2 branch from 9c49c47 to 875d04e Compare December 7, 2022 16:51
@chfast
Copy link
Member

chfast commented Dec 19, 2022

This has been added to the eof branch.

@axic
Copy link
Member

axic commented Feb 14, 2023

Is this deprecated by #563?

@gumb0 gumb0 closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gumb0 @chfast @axic