Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Introduce _hex literal to build bytes #469

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 2, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #469 (3db7174) into master (5b5bf0a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   99.58%   99.58%   -0.01%     
==========================================
  Files          37       38       +1     
  Lines        4622     4588      -34     
==========================================
- Hits         4603     4569      -34     
  Misses         19       19              
Flag Coverage Δ
consensus 79.10% <ø> (ø)
unittests 99.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/eof_test.cpp 100.00% <100.00%> (ø)
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_eof_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_memory_test.cpp 99.08% <100.00%> (-0.01%) ⬇️
test/unittests/evm_state_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_test.cpp 100.00% <100.00%> (ø)
test/utils/utils.hpp 100.00% <100.00%> (ø)

Verified

This commit was signed with the committer’s verified signature.
sandy081 Sandeep Somavarapu
@chfast chfast force-pushed the tests_hex_literal branch from f2d2b33 to 3db7174 Compare June 2, 2022 12:39
@chfast chfast requested review from gumb0, axic and yperbasis June 2, 2022 12:39
@@ -180,12 +180,12 @@ TEST(eof_validation, EOF1_undefined_opcodes)
EXPECT_EQ(validate_eof(cont), expected) << hex(cont);
}

EXPECT_EQ(validate_eof(from_hex("EF0001 010001 00 FE")), EOFValidationError::success);
EXPECT_EQ(validate_eof("EF0001 010001 00 FE"), EOFValidationError::success);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_hex missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validate_eof() takes bytecode which also ignores whitespace.

@chfast chfast merged commit fa20744 into master Jun 3, 2022
@chfast chfast deleted the tests_hex_literal branch June 3, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants