advanced: Fix JUMPI followed by stack underflow #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix stack height check for the basic block following a JUMPI instruction. Before the stack height was 1 too big because the implementation incorrectly did not remove the JUMPI condition from the stack. The bug was introduced in #457.
Merged
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 39 39
Lines 4588 4593 +5
=======================================
+ Hits 4569 4574 +5
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stack height check for the basic block following a JUMPI instruction.
Before the stack height was 1 too big because the implementation
incorrectly did not remove the JUMPI condition from the stack.
The bug was introduced in #457.