state: Define MPT root hash procedure for accounts #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
Jul 5, 2022
gumb0
reviewed
Jul 5, 2022
| MPT trie; | ||
| for (const auto& [key, value] : storage) | ||
| { | ||
| if (!is_zero(value.current)) // Skip "deleted" values. |
There was a problem hiding this comment.
Maybe this is rather logic of how MPT data structure is used in Ethereum... so not logic of hashing itself, may be better kept outside.
But I don't mind either way.
There was a problem hiding this comment.
Both "hash functions" are use-case specific because at least you need to decide how to serialize a structure. As long as we will keep original and current value together we cannot erase instead of zeroing.
In more generic fashion in this case std::copy_if could be used if we support std::insterter(). In the other case we would need something like "transform if" so ranges should be more suited. Interesting exercise, but decided is too big detour.
gumb0
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.