Implement gas refund #493
Merged
Implement gas refund #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
refund
branch
2 times, most recently
from
bb7d211
to
a6121d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 99.39% 99.40% +0.01%
==========================================
Files 53 53
Lines 5145 5249 +104
==========================================
+ Hits 5114 5218 +104
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
instructions_storage
branch
from
7e25e13
to
5350ed2
Compare
gumb0
reviewed
Aug 18, 2022
chfast
commented
Aug 18, 2022
gumb0
reviewed
Aug 19, 2022
test/unittests/evm_storage_test.cpp
Outdated
| int64_t expected_gas_refund) { | ||
| auto& storage = host.accounts[msg.recipient].storage; | ||
| storage[key] = {current, original}; | ||
| execute(sstore(0xef, calldataload(0)), value); |
There was a problem hiding this comment.
maybe could be simpler
Suggested change
| execute(sstore(0xef, calldataload(0)), value); | |
| execute(sstore(0xef, value), {}); |
gumb0
reviewed
Aug 19, 2022
test/unittests/evm_storage_test.cpp
Outdated
| int64_t clear = -1; | ||
| }; | ||
|
|
||
| auto test = [this](const evmc::bytes32& original, const evmc::bytes32& current, |
There was a problem hiding this comment.
Could this helper be reused between two tests?
There was a problem hiding this comment.
This is rather difficult because it accesses this.
gumb0
reviewed
Aug 19, 2022
| EXPECT_GAS_USED(EVMC_SUCCESS, 7603); // Cold access to 0xbe. | ||
| EXPECT_EQ(result.gas_refund, 24000); | ||
|
|
||
| // Second selfdestruct of the same account. |
There was a problem hiding this comment.
Maybe also add a test for another selfdestruct of different account
gumb0
reviewed
Aug 19, 2022
|
|
||
| const auto a = 0xaa_address; | ||
| const auto code = | ||
| call(a) + callcode(a) + delegatecall(a) + staticcall(a) + create() + create2(); |
There was a problem hiding this comment.
may be redundant, but I thought of having two calls of each type to check that it's also aggregated for same type calls.
gumb0
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate, aggregate and report the gas refund. This requires changes to
SSTORE,SELFDESTRUCTand calls (propagate gas refund).