EIP-4750: EOF - Functions #497

gumb0 · 2022-08-23T14:09:10Z

No description provided.

axic · 2022-08-23T21:51:54Z

lib/evmone/eof.cpp

+           section_count * section_header_size + sizeof(TERMINATOR);
+}
+
+std::pair<EOFSectionHeaders, EOFValidationError> validate_eof_headers(bytes_view container)


Why is this not noexcept anymore?

Number of sections is arbitrary now and so function does dynamic allocation (to return all sections' sizes)

axic · 2022-08-23T21:54:15Z

lib/evmone/eof.cpp

            case DATA_SECTION:
-                if (section_headers[CODE_SECTION] == 0)


I think you can't remove this from here?

It's replaced by another check in case CODE_SECTION:

if (!section_headers[DATA_SECTION].empty()) return {{}, EOFValidationError::data_section_before_code_section};

(because now invalid case can be like code-data-code)

plus the old check in case TERMINATOR guarantees that at least one code section is present.

codecov · 2022-09-08T14:10:32Z

Codecov Report

Merging #497 (75a38b2) into eof-static-jumps2 (6d03f5d) will decrease coverage by 0.65%.
The diff coverage is 92.82%.

❗ Current head 75a38b2 differs from pull request most recent head e463a46. Consider uploading reports for the commit e463a46 to get more accurate results

Additional details and impacted files

@@                  Coverage Diff                  @@
##           eof-static-jumps2     #497      +/-   ##
=====================================================
- Coverage              98.03%   97.37%   -0.66%     
=====================================================
  Files                     59       64       +5     
  Lines                   5687     6390     +703     
=====================================================
+ Hits                    5575     6222     +647     
- Misses                   112      168      +56

Flag	Coverage Δ
blockchaintests	`69.50% <6.21%> (-8.66%)`	⬇️
statetests	`77.26% <73.70%> (+4.49%)`	⬆️
unittests	`89.80% <76.14%> (-1.92%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/evmone/eof.hpp	`100.00% <ø> (ø)`
lib/evmone/execution_state.hpp	`94.54% <ø> (ø)`
test/state/precompiles.hpp	`0.00% <0.00%> (ø)`
test/unittests/evm_fixture.hpp	`100.00% <ø> (ø)`
test/state/precompiles_cache.cpp	`50.00% <50.00%> (ø)`
test/statetest/statetest_loader.cpp	`76.47% <52.38%> (-4.40%)`	⬇️
lib/evmone/instructions_calls.cpp	`98.14% <75.00%> (-1.86%)`	⬇️
test/state/host.cpp	`80.31% <75.00%> (-0.23%)`	⬇️
lib/evmone/eips.hpp	`83.33% <83.33%> (ø)`
test/state/precompiles.cpp	`83.15% <86.20%> (+16.49%)`	⬆️
... and 22 more

gumb0 · 2022-12-06T19:05:17Z

Rebased, updated opcodes and gas prices for CALLF/RETF and made it activated in Shanghai.

Implement EIP-663: Unlimited SWAP and DUP instructions

gumb0 · 2022-12-28T19:36:45Z

lib/evmone/instructions.hpp

+        const auto rel_offset_hi = pc[1 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];
+        const auto rel_offset_lo = pc[2 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];


Is this off-by-one error?

Suggested change

const auto rel_offset_hi = pc[1 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];

const auto rel_offset_lo = pc[2 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];

const auto rel_offset_hi = pc[2 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];

const auto rel_offset_lo = pc[3 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];

pc[1] is count, for case == 0, it should take pc[2] and pc[3].

gumb0 · 2022-12-29T11:47:09Z

test/utils/bytecode.hpp

+    return condition + OP_RJUMPI + bytecode{big_endian(offset)};
+}
+
+inline bytecode rjumpv(const std::initializer_list<uint16_t> offsets, bytecode condition)


sorry this was wrong

Suggested change

inline bytecode rjumpv(const std::initializer_list<uint16_t> offsets, bytecode condition)

inline bytecode rjumpv(const std::initializer_list<int16_t> offsets, bytecode condition)

gumb0 · 2023-01-02T14:03:56Z

lib/evmone/eof.cpp

+
+    for (const auto& t : types)
+    {
+        if (t.max_stack_height > MAX_STACK_HEIGHT)


According to EIP-5450 max stack height doesn't exceed 1023

Suggested change

if (t.max_stack_height > MAX_STACK_HEIGHT)

if (t.max_stack_height >= MAX_STACK_HEIGHT)

axic · 2023-02-14T12:03:32Z

Is this deprecated by #563?

axic reviewed Aug 23, 2022

View reviewed changes

gumb0 force-pushed the eof-functions branch 3 times, most recently from ef30ed0 to 41acfad Compare September 8, 2022 14:05

gumb0 force-pushed the eof-functions branch 2 times, most recently from a2f706b to 72c70b4 Compare September 13, 2022 10:45

chfast force-pushed the eof-static-jumps2 branch 4 times, most recently from 3da226a to ceb4032 Compare September 28, 2022 16:05

chfast force-pushed the eof-functions branch from 4a7c4be to 1bc4f69 Compare September 28, 2022 16:12

gumb0 force-pushed the eof-static-jumps2 branch 4 times, most recently from 3e89dde to 1ab5b19 Compare December 6, 2022 14:10

gumb0 force-pushed the eof-functions branch from b81d112 to 6812e21 Compare December 6, 2022 19:04

gumb0 force-pushed the eof-functions branch from 6812e21 to cf7c705 Compare December 7, 2022 10:34

gumb0 force-pushed the eof-static-jumps2 branch 2 times, most recently from 9c49c47 to 875d04e Compare December 7, 2022 16:51

gumb0 and others added 8 commits December 13, 2022 12:41

test: Helper to check if current VM is Advanced

581ce39

baseline: Implement EIP-663 DUPN SWAPN

4b1dad4

test: Add EIP-663 DUPN SWAPN unit tests

3e0ab0e

Merge pull request #529 from ethereum/eip-663

b6d103b

Implement EIP-663: Unlimited SWAP and DUP instructions

Set Opcode underlaying storage to uint8_t (#537)

b14fad9

precompiles: Implement gas cost analysis

94b8a92

precompiles: Cache precompiles' execution results

c776b42

precompiles: Dump and load precompiles' cache

15fe385

Fix sanitizers error

f023c37

rodiazet force-pushed the eof-functions branch from 8310c73 to f023c37 Compare December 23, 2022 09:53

rodiazet and others added 3 commits December 27, 2022 16:20

Implement max stack height validation

b33a74e

eof: Switch instruction validation to baseline cost table

a5f2c4f

eof: Reject deprecated instructions

bcc15ac

chfast force-pushed the eof-functions branch from 4faa8ce to bcc15ac Compare December 27, 2022 15:20

eof: Fix unit tests

f4ea517

rodiazet force-pushed the eof-functions branch from e844a66 to f4ea517 Compare December 27, 2022 16:42

chfast and others added 2 commits December 28, 2022 09:17

test: Add EOF data only contract test

8c041ed

Fix sanitizers testing error

1c91f92

rodiazet force-pushed the eof-functions branch from 20c499c to 1c91f92 Compare December 28, 2022 11:51

chfast and others added 2 commits December 28, 2022 15:53

host: Enforce EOF code from EOF initcode

4667b64

eof: Ensure that eof contract creates only valid eof contract

79baead

rodiazet force-pushed the eof-functions branch from 09c7e79 to 79baead Compare December 28, 2022 16:20

gumb0 commented Dec 28, 2022

View reviewed changes

test: Add basic test for RJUMPV

403e970

gumb0 force-pushed the eof-functions branch from f24c127 to 403e970 Compare December 28, 2022 20:19

Fix off-by-one error in RJUMPV implementation

21c6466

gumb0 commented Dec 29, 2022

View reviewed changes

rodiazet added 6 commits December 29, 2022 16:54

eof: Add more RJUMPV tests

f6e6b43

eof: Fix 0 count RJUMPV test

4e0e7d4

Fix linter errors

dcbc983

eof: Add long jump test for RJUMPV

b051628

eof: Limit number of possible inputs and outputs.

7bd9567

eof: Add tests for max stack height

5ca9116

gumb0 commented Jan 2, 2023

View reviewed changes

chfast added 2 commits January 2, 2023 16:54

eof: get_error_message()

0520f2e

Add eofparse testing tool

62bddb3

gumb0 closed this Feb 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-4750: EOF - Functions #497

EIP-4750: EOF - Functions #497

gumb0 commented Aug 23, 2022

axic Aug 23, 2022

gumb0 Aug 24, 2022

axic Aug 23, 2022

gumb0 Aug 24, 2022

codecov bot commented Sep 8, 2022 •

edited

Loading

gumb0 commented Dec 6, 2022

gumb0 Dec 28, 2022

gumb0 Dec 29, 2022

gumb0 Jan 2, 2023

axic commented Feb 14, 2023

		const auto rel_offset_hi = pc[1 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];
		const auto rel_offset_lo = pc[2 + static_cast<uint16_t>(case_) * REL_OFFSET_SIZE];

	inline bytecode rjumpv(const std::initializer_list<uint16_t> offsets, bytecode condition)
	inline bytecode rjumpv(const std::initializer_list<int16_t> offsets, bytecode condition)

	if (t.max_stack_height > MAX_STACK_HEIGHT)
	if (t.max_stack_height >= MAX_STACK_HEIGHT)

EIP-4750: EOF - Functions #497

EIP-4750: EOF - Functions #497

Conversation

gumb0 commented Aug 23, 2022

axic Aug 23, 2022

Choose a reason for hiding this comment

gumb0 Aug 24, 2022

Choose a reason for hiding this comment

axic Aug 23, 2022

Choose a reason for hiding this comment

gumb0 Aug 24, 2022

Choose a reason for hiding this comment

codecov bot commented Sep 8, 2022 • edited Loading

Codecov Report

gumb0 commented Dec 6, 2022

gumb0 Dec 28, 2022

Choose a reason for hiding this comment

gumb0 Dec 29, 2022

Choose a reason for hiding this comment

gumb0 Jan 2, 2023

Choose a reason for hiding this comment

axic commented Feb 14, 2023

codecov bot commented Sep 8, 2022 •

edited

Loading