EOFCREATE and RETURNCONTRACT implementation #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
eof-create3
branch
2 times, most recently
from
1e9a68a
to
17dd8f8
Compare
gumb0
force-pushed
the
eof-create3
branch
6 times, most recently
from
e5b5a78
to
8b25057
Compare
axic
reviewed
Feb 6, 2023
axic
reviewed
Feb 6, 2023
axic
reviewed
Feb 6, 2023
axic
reviewed
Feb 6, 2023
lib/evmone/instructions_traits.hpp
Outdated
| @@ -171,6 +171,8 @@ constexpr inline GasCostTable gas_costs = []() noexcept { | |||
| table[EVMC_CANCUN] = table[EVMC_SHANGHAI]; | |||
| table[EVMC_CANCUN][OP_DUPN] = 3; | |||
| table[EVMC_CANCUN][OP_SWAPN] = 3; | |||
| table[EVMC_CANCUN][OP_CREATE3] = 32000; | |||
| table[EVMC_CANCUN][OP_RETURNCONTRACT] = 0; | |||
There was a problem hiding this comment.
To think about this: probably neither of these prices are good?
gumb0
force-pushed
the
eof-create3
branch
4 times, most recently
from
82013aa
to
f8f095b
Compare
rodiazet
force-pushed
the
eof
branch
2 times, most recently
from
219821b
to
3987c3d
Compare
gumb0
force-pushed
the
eof-create3
branch
8 times, most recently
from
860b84f
to
b4b4aa0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 98.17% 98.25% +0.08%
==========================================
Files 129 129
Lines 13767 14644 +877
==========================================
+ Hits 13516 14389 +873
- Misses 251 255 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
force-pushed
the
eof
branch
2 times, most recently
from
91b770f
to
ef94b4e
Compare
chfast
force-pushed
the
master
branch
2 times, most recently
from
7717742
to
d5e55fc
Compare
gumb0
force-pushed
the
eof-create3
branch
2 times, most recently
from
cd00f11
to
80e5b44
Compare
|
Not sure yet what happened to the coverage now, it was almost everything covered some time ago 😞 |
Seems to be beacause |
gumb0
force-pushed
the
eof-create3
branch
4 times, most recently
from
4a02f97
to
3599674
Compare
gumb0
force-pushed
the
eof-create3
branch
2 times, most recently
from
67cbffe
to
f395362
Compare
|
Rebased. |
pdobacz
approved these changes
Apr 15, 2024
Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
Also support EOFCREATE and EOF with containers in bytecode helper. Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
[ ] Optimization to replace validation recursion with iterationcreated separate issue EOF: Nested container validation without recursion #794