-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load BlockInfo fixes required by exec-spec-tests #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Mar 15, 2023
rodiazet
changed the title
BlockInfo loader unit test
Load BlockInfo fixes required by exec-spec-tests
Mar 21, 2023
rodiazet
force-pushed
the
bi-load-test
branch
2 times, most recently
from
March 21, 2023 12:08
7bd0c5a
to
bd4a899
Compare
chfast
reviewed
Mar 21, 2023
axic
reviewed
Mar 21, 2023
rodiazet
force-pushed
the
bi-load-test
branch
2 times, most recently
from
March 21, 2023 14:12
14e3c7b
to
134866b
Compare
chfast
force-pushed
the
bi-load-test
branch
2 times, most recently
from
March 27, 2023 11:10
c75ad06
to
be80c7d
Compare
chfast
approved these changes
Mar 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 96.85% 97.07% +0.21%
==========================================
Files 73 74 +1
Lines 7276 7375 +99
==========================================
+ Hits 7047 7159 +112
+ Misses 229 216 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add tests cases for BlockInfo loader according to bugs reported.
-Extend
from_json
implementation for64
bits integers to supporthex
anddec
strings and values-Add special case handling to suport
currentRandom
passed as0
.execution-spec-tests
requires it.