Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: Fix clang-17 compiler warnings #597

Merged
merged 1 commit into from
Mar 26, 2023
Merged

bench: Fix clang-17 compiler warnings #597

merged 1 commit into from
Mar 26, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Mar 26, 2023

Avoid -Wshadow warnings from clang-17. The proper fix is in #596 but we cannot apply it yet due to insufficient compiler support.

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #597 (d57a765) into master (0cfd850) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          73       73           
  Lines        7276     7276           
=======================================
  Hits         7047     7047           
  Misses        229      229           
Flag Coverage Δ
blockchaintests 63.71% <ø> (ø)
statetests 63.10% <ø> (ø)
unittests 93.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chfast chfast merged commit dd1b623 into master Mar 26, 2023
@chfast chfast deleted the clang17_shadow branch March 26, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant