Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: Separate gas parameter #599

Merged
merged 1 commit into from
Apr 6, 2023
Merged

tracing: Separate gas parameter #599

merged 1 commit into from
Apr 6, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Mar 28, 2023

Decouple "gas left" from ExecutionState and pass it as separate param.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #599 (abec11f) into master (7e4c268) will not change coverage.
The diff coverage is 100.00%.

❗ Current head abec11f differs from pull request most recent head 477dd5b. Consider uploading reports for the commit 477dd5b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          74       74           
  Lines        7445     7445           
=======================================
  Hits         7230     7230           
  Misses        215      215           
Flag Coverage Δ
blockchaintests 63.61% <0.00%> (ø)
statetests 63.09% <0.00%> (ø)
unittests 93.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/tracing_test.cpp 100.00% <ø> (ø)
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
lib/evmone/tracing.cpp 100.00% <100.00%> (ø)
lib/evmone/tracing.hpp 94.11% <100.00%> (ø)

... and 2 files with indirect coverage changes

@axic
Copy link
Member

axic commented Mar 28, 2023

What is the motivation?

@chfast
Copy link
Member Author

chfast commented Mar 28, 2023

We are going to remove gas_left from ExecutionState in next PR.

@chfast
Copy link
Member Author

chfast commented Mar 28, 2023

See continuation in #600.

@chfast chfast requested review from gumb0 and rodiazet April 5, 2023 08:35
Base automatically changed from memory_grow to master April 5, 2023 08:51
@rodiazet
Copy link
Contributor

rodiazet commented Apr 5, 2023

state.gas_left is used also in a couple of different places in the code. Are you going to separate it in additional PRs?

@chfast
Copy link
Member Author

chfast commented Apr 5, 2023

See continuation in #600.

Decouple "gas left" from ExecutionState and pass it as separate param.
@chfast chfast merged commit 4cb88b8 into master Apr 6, 2023
@chfast chfast deleted the tracing_gas branch April 6, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants