Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate deployed EOF code before state test execution #601

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

rodiazet
Copy link
Collaborator

No description provided.

@rodiazet rodiazet requested a review from chfast March 28, 2023 13:59
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #601 (bbc7e60) into master (7e4c268) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head bbc7e60 differs from pull request most recent head 2df3dcb. Consider uploading reports for the commit 2df3dcb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   97.11%   97.15%   +0.04%     
==========================================
  Files          74       74              
  Lines        7445     7462      +17     
==========================================
+ Hits         7230     7250      +20     
+ Misses        215      212       -3     
Flag Coverage Δ
blockchaintests 63.61% <ø> (ø)
statetests 63.03% <38.46%> (-0.07%) ⬇️
unittests 94.01% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest.hpp 100.00% <ø> (ø)
test/statetest/statetest_loader.cpp 89.54% <100.00%> (+1.08%) ⬆️
test/statetest/statetest_runner.cpp 100.00% <100.00%> (ø)
test/unittests/statetest_loader_test.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@chfast
Copy link
Member

chfast commented Mar 28, 2023

Why?

@rodiazet
Copy link
Collaborator Author

rodiazet commented Mar 28, 2023

Why?

Because validate_eof fails for every EOF for pre-Cancun. A lot of state tests started failing after adding this validation.

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point this is too big. You needed to move it to a helper function.

test/statetest/statetest_runner.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the state-tests-fix branch 2 times, most recently from 7a44ad5 to bbc7e60 Compare April 6, 2023 09:55
@chfast chfast changed the title Enable state test deployed code EOF verification since Cancun Validate deployed EOF code before state test execution Apr 6, 2023
@chfast chfast merged commit d1423c7 into master Apr 6, 2023
@chfast chfast deleted the state-tests-fix branch April 6, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants