Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional storage field in input alloc. #606

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

rodiazet
Copy link
Collaborator

No description provided.

@rodiazet rodiazet requested a review from chfast March 30, 2023 09:55
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #606 (213793d) into master (f835186) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          74       74           
  Lines        7443     7445    +2     
=======================================
+ Hits         7228     7230    +2     
  Misses        215      215           
Flag Coverage Δ
blockchaintests 63.55% <ø> (ø)
statetests 63.06% <100.00%> (+0.03%) ⬆️
unittests 93.95% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest_loader.cpp 88.46% <100.00%> (+0.11%) ⬆️

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not put full stop in a git commit title.

@rodiazet rodiazet merged commit 0028d4d into master Mar 30, 2023
@rodiazet rodiazet deleted the t8n-storage branch March 30, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants