Fix and improve eof.read_valid_eof1_header test #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
read-valid-eof1-header-fix
branch
from
8da7e5f to
96c3118
Compare
gumb0
force-pushed
the
read-valid-eof1-header-fix
branch
from
96c3118 to
78d12f9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 97.38% 97.37% -0.01%
==========================================
Files 80 80
Lines 7949 7958 +9
==========================================
+ Hits 7741 7749 +8
- Misses 208 209 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
approved these changes
Jun 1, 2023
| }; | ||
| std::string nops_255; | ||
| for (int i = 0; i < 255; ++i) |
There was a problem hiding this comment.
I don't think so, because fill_n() is only for filling with one repeated character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.