Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DATALOADN truncated immediate validation #663

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jun 6, 2023

Problem fixed: DATALOADN validation was reading the immediate value before checking it's not truncated.

@gumb0 gumb0 requested review from chfast and rodiazet June 6, 2023 13:41
@gumb0 gumb0 added the EOF label Jun 6, 2023
@gumb0 gumb0 requested a review from axic June 6, 2023 13:48
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #663 (6c08a08) into master (6e2a589) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   97.37%   97.38%   +0.01%     
==========================================
  Files          80       80              
  Lines        7958     7964       +6     
==========================================
+ Hits         7749     7756       +7     
+ Misses        209      208       -1     
Flag Coverage Δ
blockchaintests 63.17% <0.00%> (+0.04%) ⬆️
statetests 73.98% <100.00%> (-0.02%) ⬇️
unittests 94.95% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/instructions_test.cpp 89.58% <ø> (ø)
lib/evmone/eof.cpp 83.28% <100.00%> (+0.26%) ⬆️
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)

@chfast chfast merged commit 367c51c into master Jun 18, 2023
@chfast chfast deleted the dataloadn-truncated-imm branch June 18, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants