EOFTests #678
Merged
EOFTests #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
Aug 9, 2023
|
Please squash the commits |
gumb0
reviewed
Aug 10, 2023
gumb0
reviewed
Aug 10, 2023
gumb0
reviewed
Aug 10, 2023
gumb0
reviewed
Aug 10, 2023
gumb0
reviewed
Aug 10, 2023
|
Please squash the commits |
gumb0
reviewed
Aug 11, 2023
gzanitti
force-pushed
the
EOFTests
branch
2 times, most recently
from
e5c55e4 to
7c121f5
Compare
gumb0
requested changes
Aug 14, 2023
|
@gumb0 some of the tests fail because of the emplace_back (probably a version problem), should I roll back the change? |
gumb0
reviewed
Aug 16, 2023
|
Looks good to me now, please squash once again |
|
I rebased and changed commit message. |
chfast
requested changes
Aug 22, 2023
chfast
requested changes
Aug 23, 2023
gumb0
force-pushed
the
EOFTests
branch
3 times, most recently
from
0178637 to
00ef19c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 97.60% 97.59% -0.02%
==========================================
Files 94 95 +1
Lines 8644 8644
==========================================
- Hits 8437 8436 -1
- Misses 207 208 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
EOFTests
branch
5 times, most recently
from
172be76 to
74196ff
Compare
Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
Co-authored-by: Andrei Maiboroda <andrei@ethereum.org>
gumb0
approved these changes
Sep 26, 2023
chfast
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary code to run the EOF tests.
Note: The value of the exception field is not validated, following what we discussed in our first meeting.