Blockchain tests support: Fix tx receipt rlp encoding #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #680 +/- ##
==========================================
- Coverage 97.54% 97.53% -0.01%
==========================================
Files 86 86
Lines 8215 8236 +21
==========================================
+ Hits 8013 8033 +20
- Misses 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rodiazet
changed the title
rodiazet
force-pushed
the
fix-tx-receipt-rlp-encoding
branch
2 times, most recently
from
1e4836f to
6483ab1
Compare
chfast
requested changes
Aug 18, 2023
| // Block taken from Ethereum mainnet | ||
| // https://etherscan.io/txs?block=4276370 | ||
|
|
||
| TransactionReceipt receipt0{}; |
There was a problem hiding this comment.
I think you can use designated initializers: receipt0{.type=...}.
rodiazet
force-pushed
the
fix-tx-receipt-rlp-encoding
branch
4 times, most recently
from
3f843bb to
837061d
Compare
chfast
requested changes
Aug 21, 2023
test/state/state.cpp
Outdated
| @@ -212,7 +213,9 @@ std::variant<TransactionReceipt, std::error_code> transition(State& state, const | |||
| std::erase_if(state.get_accounts(), | |||
| [](const std::pair<const address, Account>& p) noexcept { return p.second.destructed; }); | |||
|
|
|||
| auto receipt = TransactionReceipt{tx.type, result.status_code, gas_used, host.take_logs(), {}}; | |||
| // Cumulative gas used is unknown in this scope. | |||
| auto receipt = | |||
There was a problem hiding this comment.
Use simpler syntax.
Suggested change
| auto receipt = | |
| TransactionReceipt receipt{...}; |
test/state/state.hpp
Outdated
| std::vector<Log> logs; | ||
| BloomFilter logs_bloom_filter; | ||
| /// Root hash of the state after this transaction. It's used in old pre-Byzantium transaction |
There was a problem hiding this comment.
Suggested change
| /// Root hash of the state after this transaction. It's used in old pre-Byzantium transaction | |
| /// Root hash of the state after this transaction. Used only in old pre-Byzantium transactions. |
| @@ -138,9 +138,15 @@ struct TransactionReceipt | |||
| { | |||
There was a problem hiding this comment.
Add documentation of TransactionReceipt.
/// Transaction Receipt
///
/// This struct is used in two contexts:
/// 1. As the formally specified, RLP-encode transaction receipt included in the Ethereum blocks.
/// 2. As the internal representation of the transaction execution result.
/// These both roles share most, but not all the information. There are some fields that cannot be assigned in the single transaction execution context. There are also fields that are not a part of the RLP-encoded transaction receipts.
/// TODO: Consider splitting the struct into two based on the duality explained above.
rodiazet
force-pushed
the
fix-tx-receipt-rlp-encoding
branch
2 times, most recently
from
cbc36c8 to
619afad
Compare
chfast
approved these changes
Aug 21, 2023
rodiazet
force-pushed
the
fix-tx-receipt-rlp-encoding
branch
from
619afad to
70f083f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cumulative_gas_usedinstead ofgas_used