Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t8n: Add withdrawalsRoot to result #693

Conversation

danceratopz
Copy link
Member

Adds withdrawalsRoot to evmone-t8n's output result.

When evmone-t8n support was initially added to ethereum/execution-spec-tests, the framework didn't verify all block header fields. This was subsequently added in ethereum/execution-spec-tests#217, which causes test cases executed for fork=Shanghai to fail with evmone-t8n. This PR remedies the fails by adding the withdrawalsRoot to t8n's output.

With this PR, all tests pass against ethereum/execution-spec-tests@af3d64f and the withdrawalsRoot matches that of geth 1.12.2-stable-bed84606.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #693 (424c094) into master (35f4141) will decrease coverage by 0.11%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   97.53%   97.42%   -0.11%     
==========================================
  Files          86       86              
  Lines        8236     8246      +10     
==========================================
+ Hits         8033     8034       +1     
- Misses        203      212       +9     
Flag Coverage Δ
blockchaintests 62.71% <ø> (ø)
statetests 73.61% <0.00%> (-0.33%) ⬇️
statetests-silkpre 23.15% <0.00%> (-0.04%) ⬇️
unittests 95.03% <33.33%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
test/state/mpt_hash.cpp 76.47% <0.00%> (-23.53%) ⬇️
test/state/state.hpp 100.00% <ø> (ø)
test/statetest/statetest_loader.cpp 90.25% <100.00%> (+0.08%) ⬆️
test/unittests/state_transition_block_test.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@rodiazet
Copy link
Collaborator

It's done already in #690
It's going to be merged soon.

@danceratopz
Copy link
Member Author

Great, thanks! Ran #690:

simpsons

@rodiazet
Copy link
Collaborator

@danceratopz It's in master now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants