Build and test riscv32 #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
commented
Sep 2, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 94 94
Lines 8644 8644
=======================================
Hits 8437 8437
Misses 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. |
rodiazet
approved these changes
Sep 2, 2023
axic
reviewed
Sep 2, 2023
|
|
||
| set(RISCV /usr/local/riscv) | ||
|
|
||
| set(CMAKE_SYSTEM_PROCESSOR riscv32) |
There was a problem hiding this comment.
Can we specify the riscv32imac triple?
There was a problem hiding this comment.
This value is only informational, but you can modify the compiler flags.
By default it builds as rv32imafdc. If we switch to rv32imac it will not build because the included glibc is not compatible (the ABI for floating-point values is different). We can configure and build the toolchain ourselves but seems to be a lot of work for the start.
chfast
force-pushed
the
riscv32
branch
7 times, most recently
from
b6b1fe0 to
52c710e
Compare
Use CMake target name directly in add_test() to make it work with `CROSSCOMPILING_EMULATOR`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a pre-built RISC-V toolchain to build and test evmone.
This compiles evmone and dependencies to
rv32imafdcwithilp32dABI. I.e. this target has hardware support for floating point.Our preference would be to compile for
rv32imacwithilp32ABI. However, there are some obstacles to get there:ilp32d. We would need to build the toolchain ourselves.-march=rv32imac -mabi=ilp32d. The compiler is not very happy about using architecture with incompatible ABI but it will proceed anyway. Unfortunately, the dependencies have some floating-point code so we also need to provide soft-float library. I was not able to make it build so far.