Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockchain tests runner #711

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Blockchain tests runner #711

merged 7 commits into from
Oct 2, 2023

Conversation

rodiazet
Copy link
Collaborator

  • Several changes making functions visible for blockchain tests.
  • Support different naming of several fields in json format of transaction
  • Implement blockchain tests loader and runner
  • Add unit test for blockchain test loader
  • Invalid tx and blocks are not supported yet

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #711 (3b7d631) into master (099a229) will decrease coverage by 0.03%.
The diff coverage is 95.89%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   97.73%   97.70%   -0.03%     
==========================================
  Files          98      101       +3     
  Lines        9235     9376     +141     
==========================================
+ Hits         9026     9161     +135     
- Misses        209      215       +6
Flag Coverage Δ
blockchaintests 62.37% <ø> (ø)
statetests 65.05% <80.00%> (+2.82%) ⬆️
statetests-silkpre 26.14% <0.00%> (-0.43%) ⬇️
unittests 95.70% <97.22%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/bloom_filter.cpp 100.00% <100.00%> (ø)
test/state/bloom_filter.hpp 100.00% <ø> (ø)
test/state/state.cpp 100.00% <ø> (+1.22%) ⬆️
test/state/state.hpp 100.00% <ø> (ø)
test/statetest/statetest.hpp 84.61% <ø> (-15.39%) ⬇️
test/statetest/statetest_loader.cpp 96.10% <100.00%> (+0.06%) ⬆️
test/unittests/blockchaintest_loader_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_bloom_filter_test.cpp 100.00% <ø> (ø)
test/blockchaintest/blockchaintest.hpp 0.00% <0.00%> (ø)
test/blockchaintest/blockchaintest_loader.cpp 93.93% <93.93%> (ø)

@rodiazet rodiazet requested review from chfast and gumb0 September 26, 2023 15:52
@rodiazet rodiazet force-pushed the blockchain-tests-loader branch from e8fcef7 to 8ac2674 Compare September 26, 2023 15:58
chfast
chfast reviewed Sep 26, 2023
View reviewed changes
test/blockchaintest/blockchaintest.hpp Show resolved Hide resolved
test/blockchaintest/blockchaintest.hpp Show resolved Hide resolved
test/blockchaintest/blockchaintest.hpp Outdated Show resolved Hide resolved
test/blockchaintest/blockchaintest.hpp Outdated Show resolved Hide resolved
test/blockchaintest/blockchaintest_loader.cpp Outdated Show resolved Hide resolved
test/blockchaintest/blockchaintest_loader.cpp Outdated Show resolved Hide resolved
chfast
chfast reviewed Sep 26, 2023
View reviewed changes
test/blockchaintest/CMakeLists.txt Outdated Show resolved Hide resolved
test/blockchaintest/blockchaintest.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the blockchain-tests-loader branch 2 times, most recently from 1efc06c to e951d86 Compare September 27, 2023 07:51
@rodiazet rodiazet requested a review from chfast September 27, 2023 08:03
@rodiazet rodiazet force-pushed the blockchain-tests-loader branch 4 times, most recently from 79e29e5 to 12bc2c1 Compare September 28, 2023 09:18
@rodiazet rodiazet requested a review from chfast September 28, 2023 09:22
@chfast chfast force-pushed the blockchain-tests-loader branch 3 times, most recently from ec335dd to 1762edf Compare September 30, 2023 13:05
@chfast chfast changed the title Blockchain tests loader Blockchain tests runner Sep 30, 2023
@chfast chfast force-pushed the blockchain-tests-loader branch 2 times, most recently from 2f5afed to 1d0ff04 Compare September 30, 2023 13:43
@rodiazet rodiazet force-pushed the blockchain-tests-loader branch 6 times, most recently from f4cee1e to 849983f Compare October 2, 2023 11:06
@rodiazet @chfast
state: Export bloom_filter_from_bytes()
aeebedf 
Make `bloom_filter_from_bytes()` available to blockchain tests too.
rodiazet and others added 6 commits October 2, 2023 13:33
@rodiazet @chfast
state: Make function parameters const
f302d0f 
Make `Ommers` and `Withdrawals` parameters `const`
in `finalize()` function.
@rodiazet @chfast
test: Export loading of JSON tests primitives
4b7f098 
Make `address`, `hash256` and `bytes` loading from JSON available to
blockchain tests.
@rodiazet @chfast
test: Support alternative key names for JSON tests
e89677d 
Support alternative representation of transaction `data`
and `gasLimit` fields in JSON state/blockchain tests.
@rodiazet @chfast
test: Add blockchain tests runner
14126f9 
Implement JSON blockchain tests loader and runner.
Report unsupported test features with the specific exception type
and skip these tests.

Co-authored-by: Paweł Bylica <pawel@ethereum.org>
@rodiazet @chfast
test: Add unit tests for blockchain tests loading
a85bfb5
@chfast
ci: Run blockchain tests
3b7d631
@chfast chfast force-pushed the blockchain-tests-loader branch from 849983f to 3b7d631 Compare October 2, 2023 11:54
@chfast chfast self-requested a review October 2, 2023 11:57
@chfast chfast merged commit f01df56 into master Oct 2, 2023
1 of 3 checks passed
@chfast chfast deleted the blockchain-tests-loader branch October 2, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodiazet @chfast