Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clear transient storage after transaction execution #715

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 30, 2023

The transient storage EIP-1153
must not persist between transactions. Clear the transient storage
attached to every account at the end of transaction execution.

@chfast chfast added the Cancun Changes for Cancun Ethereum spec revision label Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #715 (3fc6fef) into master (f01df56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         101      101           
  Lines        9376     9377    +1     
=======================================
+ Hits         9161     9162    +1     
  Misses        215      215           
Flag Coverage Δ
blockchaintests 62.37% <ø> (ø)
statetests 65.05% <100.00%> (ø)
statetests-silkpre 26.14% <100.00%> (ø)
unittests 95.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/state.cpp 100.00% <100.00%> (ø)

@rodiazet rodiazet force-pushed the blockchain-tests-loader branch 6 times, most recently from f4cee1e to 849983f Compare October 2, 2023 11:06
@chfast chfast force-pushed the blockchain-tests-loader branch from 849983f to 3b7d631 Compare October 2, 2023 11:54
Base automatically changed from blockchain-tests-loader to master October 2, 2023 12:06
chfast added 2 commits October 2, 2023 14:09
The transient storage [EIP-1153](https://eips.ethereum.org/EIPS/eip-1153)
must not persist between transactions. Clear the transient storage
attached to every account at the end of transaction execution.
@chfast chfast force-pushed the transient_storage_clear branch from 706ebe3 to 3fc6fef Compare October 2, 2023 12:09
@chfast chfast merged commit ee0bede into master Oct 2, 2023
3 checks passed
@chfast chfast deleted the transient_storage_clear branch October 2, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cancun Changes for Cancun Ethereum spec revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants