Rename error non_empty_stack_on_terminating_instruction #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugo-dc
requested review from
gumb0 and
rodiazet
and removed request for
rodiazet
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 109 109
Lines 10318 10318
=======================================
Hits 10096 10096
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
Nov 9, 2023
|
Also please change commit message to |
hugo-dc
force-pushed
the
retf-outputs
branch
2 times, most recently
from
a70a284 to
53a1b87
Compare
|
Looks good, but can you leave only RETF change in this PR, then we will merge it, and then I'll rebase JUMPF? |
Now JUMPF is merged, you can just rebase this PR instead. |
gumb0
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error
non_empty_stack_on_terminating_instructionis currently only used when there is a mismatch between the number of stack items in current function context and the total number of defined outputs, which is no longer accurate.This PR changes the error name to indicate outputs mismatch.