Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile: Add dummy point evaluation (EIP-4844) #730

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 22, 2023

Introduce EIP-4844 point evaluation precompile with dummy implementation and add JSON stub entries for it.

@chfast chfast added the Cancun Changes for Cancun Ethereum spec revision label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #730 (bd6c3de) into master (beaa0a2) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   97.72%   97.70%   -0.02%     
==========================================
  Files         106      106              
  Lines        9693     9697       +4     
==========================================
+ Hits         9472     9474       +2     
- Misses        221      223       +2     
Flag Coverage Δ
blockchaintests 62.23% <ø> (ø)
statetests 60.65% <50.00%> (-0.03%) ⬇️
statetests-silkpre 27.44% <40.00%> (-0.01%) ⬇️
unittests 95.53% <60.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/unittests/state_precompiles_test.cpp 100.00% <100.00%> (ø)
test/state/precompiles.cpp 86.92% <50.00%> (-1.00%) ⬇️

@chfast chfast force-pushed the 4844_point_evaluation_precompile branch from bc39b2a to 2bec1f7 Compare November 23, 2023 11:07
@chfast chfast changed the base branch from master to precompiles_id November 23, 2023 11:07
@chfast chfast marked this pull request as ready for review November 23, 2023 11:08
@chfast chfast requested review from gumb0, pdobacz and rodiazet November 23, 2023 11:08
@chfast chfast force-pushed the precompiles_id branch 2 times, most recently from 6d8a14d to 33a3504 Compare November 23, 2023 14:04
Base automatically changed from precompiles_id to master November 23, 2023 14:20
Introduce EIP-4844 point evaluation precompile with dummy implementation.
Add JSON stub entries for the EIP-4844 point evaluation precompile.
Inputs and outputs have been extracted from execution-spec-tests
v1.0.6 using modified geth.
@chfast chfast force-pushed the 4844_point_evaluation_precompile branch from 2bec1f7 to bd6c3de Compare November 23, 2023 14:23
@chfast chfast merged commit 2223e78 into master Nov 23, 2023
23 of 25 checks passed
@chfast chfast deleted the 4844_point_evaluation_precompile branch November 23, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cancun Changes for Cancun Ethereum spec revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants