Refactor precompiles detection #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #732 +/- ##
==========================================
+ Coverage 97.70% 97.72% +0.01%
==========================================
Files 105 106 +1
Lines 9671 9693 +22
==========================================
+ Hits 9449 9472 +23
+ Misses 222 221 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
precompiles_id
branch
from
ef9f1fc to
6c084c2
Compare
pdobacz
approved these changes
Nov 23, 2023
chfast
force-pushed
the
precompiles_id
branch
from
6c084c2 to
1886f28
Compare
chfast
force-pushed
the
precompiles_id
branch
from
1886f28 to
6d8a14d
Compare
rodiazet
reviewed
Nov 23, 2023
Extract a precompile address recognition into new is_precompile() function and use it in all places where this information is needed. Improve maintenance of "precompile ids" by adding aliases to the enum. Add unit tests for is_precompile().
chfast
force-pushed
the
precompiles_id
branch
from
6d8a14d to
33a3504
Compare
rodiazet
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract a precompile address recognition into new is_precompile()
function and use it in all places where this information is needed.
Improve maintenance of "precompile ids" by adding aliases to the enum.
Add unit tests for is_precompile().