Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statetest: Disable sync with stdio when tracing #757

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Dec 21, 2023

This increase the tracing performance. More info in the C++ spec: https://en.cppreference.com/w/cpp/io/ios_base/sync_with_stdio

@chfast chfast requested review from hugo-dc, gumb0 and rodiazet December 21, 2023 16:51
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b5cc58) 97.90% compared to head (b9cae85) 97.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files         110      110           
  Lines       10535    10536    +1     
=======================================
+ Hits        10314    10315    +1     
  Misses        221      221           
Flag Coverage Δ
blockchaintests 60.38% <ø> (ø)
statetests 62.35% <0.00%> (-0.02%) ⬇️
statetests-silkpre 26.22% <0.00%> (-0.01%) ⬇️
unittests 95.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/statetest/statetest.cpp 91.83% <100.00%> (+0.17%) ⬆️

@chfast chfast force-pushed the test/statetest_perf branch from ee1b3f1 to b9cae85 Compare December 21, 2023 20:15
@chfast chfast merged commit 89fa401 into master Dec 21, 2023
25 checks passed
@chfast chfast deleted the test/statetest_perf branch December 21, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant