-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable EOF validation before execution in evmc run
#768
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 110 110
Lines 10536 10542 +6
=======================================
+ Hits 10315 10321 +6
Misses 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ee2dd7a
to
d905ee9
Compare
I initially missed the possibilities to cover the new lines with tests, but codecov assisted me. It is now done. I'll squash the 2 commits before merge |
I think this is relatively good approach. Any other comments how useful it is in practice? |
I wish there was a natural way to have it "on" by default when running from the CLI, but there is no natural way to set it as default in One thought I got today is we can have the option "on" be default, but always disable it when running in a controlled environment, when we know revalidation isn't necessary. Setting the option would however be an overhead on each On more thought, the |
Of course, ultimate solution is to add We have a bunch of options, WDYT? |
I think EVMC is unnecessary overhead because there are no EVM implementations other than evmone. At some point we should create a |
hold on then, if this is the long-term plan, it sounds like a case for the "won't fix" option, let's just document the |
I think this is fine for now. Solidity is using EVMC/evmone so this may be handy for them. |
Closes #585
Not sure about placement and API. I assumed it should be off by default, and not concern
evmc
code, this is what I've got as a result.