-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DUPN and SWAPN in EOF only + EOF stack validation #788
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 110 110
Lines 10644 10670 +26
=======================================
+ Hits 10422 10448 +26
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
|
76ad926
to
7bd98c5
Compare
I think the compiler generates these functions anyway, they are just not assigned to the instruction table. |
2745c69
to
bcedb55
Compare
bcedb55
to
922e9ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Fix" is a bit misleading. Maybe change the commit title to
Change the stack_height_required range to accommodate DUPN/SWAPN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test for legacy code where the result is EVMC_UNDEFINED_INSTRUCTION
is missing.
I'm planning to squash. The commit was split out for the sake of review back&forth
👍 |
922e9ee
to
c290b1c
Compare
c290b1c
to
f6ed02b
Compare
f6ed02b
to
8458134
Compare
Closes #538
Please take an extra look if the
invoke
specializations added are ok and have no undesired side effects, esp. theadvanced
counterpart. The compiler made me add the latter, even if it's not used.