test: Add some mising State Test export features #807

chfast · 2024-02-02T09:24:17Z

Add support for exporting state transition tests:

with legacy transactions (pre EIP-1559)
with access list
support EVMC spelling of revisions

codecov · 2024-02-02T09:32:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (a980168) to head (11cfcf6).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   97.93%   97.98%   +0.04%     
==========================================
  Files         116      116              
  Lines       11309    11370      +61     
==========================================
+ Hits        11076    11141      +65     
+ Misses        233      229       -4

Flag	Coverage Δ
blockchaintests	`59.75% <ø> (ø)`
statetests	`62.23% <ø> (ø)`
statetests-silkpre	`24.22% <2.85%> (-0.12%)`	⬇️
unittests	`96.25% <100.00%> (+0.19%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
test/unittests/state_transition.cpp	`97.43% <100.00%> (-0.37%)`	⬇️
test/unittests/state_transition.hpp	`0.00% <ø> (ø)`
test/unittests/state_transition_eof_test.cpp	`100.00% <100.00%> (ø)`
test/unittests/state_transition_tx_test.cpp	`100.00% <100.00%> (ø)`
test/utils/utils.cpp	`78.37% <100.00%> (+10.81%)`	⬆️

... and 1 file with indirect coverage changes

gumb0 · 2024-02-26T20:29:23Z

test/unittests/state_transition.hpp

@@ -79,7 +79,7 @@ class state_transition : public ExportableFixture
 Transaction tx{
 .gas_limit = block.gas_limit,
 .max_gas_price = block.base_fee + 1,
- .max_priority_gas_price = 1,
+ .max_priority_gas_price = block.base_fee + 1,


Why does this change? This transaction field in the spec is called max_priority_fee_per_gas and is what is added on top of block base fee.

Ah I guess because default is legacy transaction? It's confusing that Transaction has this field for legacy.

Legacy transaction requires these values to be the same. So I made the default agree as well.

Maybe this is not great for clarity of tests, but EIP-1559 calculations work for legacy transactions if these two fields have the same value of legacy gas price.

Maybe this is not great for clarity of tests, but EIP-1559 calculations work for legacy transactions if these two fields have the same value of legacy gas price.

Can't these calculations check transaction type and ignore this field (i.e. consider it equal max_gas_price) for legacy?

Or another idea is that Transaction constructor for legacy should enforce this

Yes they can, but there is no time to do this change now.

Then at least add

assert(tx.type != Legacy || tx.max_priority_gas_price == tx.max_gas_price);

to state transition.

But it also can be just

if (tx.type == Legacy) tx.max_priority_gas_price = tx.max_gas_price;

I improved the asserts in TearDown() a bit.

It looks to me that we should have something like TestBlock with every field std::optional and set default values only after test definition. Otherwise, the test definitions must fight with defaults.

chfast · 2024-02-26T20:45:38Z

test/unittests/state_transition.hpp

@@ -79,7 +79,7 @@ class state_transition : public ExportableFixture
 Transaction tx{
 .gas_limit = block.gas_limit,
 .max_gas_price = block.base_fee + 1,
- .max_priority_gas_price = 1,
+ .max_priority_gas_price = block.base_fee + 1,


Legacy transaction requires these values to be the same. So I made the default agree as well.

Maybe this is not great for clarity of tests, but EIP-1559 calculations work for legacy transactions if these two fields have the same value of legacy gas price.

chfast · 2024-02-26T20:46:37Z

test/utils/utils.cpp

@@ -13,9 +13,9 @@ evmc_revision to_rev(std::string_view s)
 return EVMC_FRONTIER;
 if (s == "Homestead")
 return EVMC_HOMESTEAD;
- if (s == "EIP150")
+ if (s == "Tangerine Whistle" || s == "EIP150")


This may not be the best idea because e.g. geth doesn't understand "Tangerine Whistle".

I changed this to export as EIP150 and EIP158... We still accept full revision names.

gumb0 · 2024-02-27T11:32:47Z

test/unittests/state_transition_tx_test.cpp

+ rev = EVMC_SPURIOUS_DRAGON;
+
+ block_reward = 0;
+ block.base_fee = 0;


Is this a valid block?

I guess for old forks it is.

gumb0 · 2024-02-27T11:37:45Z

test/unittests/state_transition.cpp

+ auto& jstorage_keys = je["storageKeys"] = json::json::array();
+ for (const auto& k : storage_keys)
+ jstorage_keys.push_back(hex0x(k));
+ ja.push_back(je);


Maybe makes sense to std::move(je)

gumb0 · 2024-02-28T09:51:37Z

test/unittests/state_transition_tx_test.cpp

 expect.tx_error = INSUFFICIENT_FUNDS;
 }

 TEST_F(state_transition, blob_tx_insuficient_funds)
 {
+ rev = EVMC_CANCUN;
+ block.base_fee = 1;


@winsvega usually says it should be at least 7 in tests, but I'm not sure exactly why

It is the minimal value by the spec.

chfast requested review from gumb0 and rodiazet February 2, 2024 09:24

chfast force-pushed the test/export branch 2 times, most recently from 2e07baf to 2646cc4 Compare February 2, 2024 14:04

chfast force-pushed the master branch from 606b735 to ffd7390 Compare February 2, 2024 14:20

chfast force-pushed the test/export branch from 2646cc4 to e849042 Compare February 2, 2024 14:24

pdobacz assigned chfast Feb 19, 2024

chfast force-pushed the test/export branch 2 times, most recently from 2680d79 to bae296a Compare February 26, 2024 10:13

gumb0 reviewed Feb 26, 2024

View reviewed changes

chfast commented Feb 26, 2024

View reviewed changes

chfast force-pushed the test/export branch from bae296a to 2271ad3 Compare February 27, 2024 10:33

gumb0 reviewed Feb 27, 2024

View reviewed changes

test: Properly export pre-1559 transactions

17c3be1

chfast force-pushed the test/export branch from 21c7a9e to c19a78e Compare February 28, 2024 08:46

gumb0 reviewed Feb 28, 2024

View reviewed changes

gumb0 approved these changes Feb 28, 2024

View reviewed changes

chfast added 2 commits February 28, 2024 11:15

test: Use common fork names in JSON export

13d6cff

test: Export transaction access list

11cfcf6

chfast force-pushed the test/export branch from c19a78e to 11cfcf6 Compare February 28, 2024 10:15

chfast merged commit 0de1555 into master Feb 28, 2024
25 checks passed

chfast deleted the test/export branch February 28, 2024 10:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add some mising State Test export features #807

test: Add some mising State Test export features #807

chfast commented Feb 2, 2024

codecov bot commented Feb 2, 2024 •

edited

Loading

gumb0 Feb 26, 2024

gumb0 Feb 26, 2024

chfast Feb 26, 2024

gumb0 Feb 27, 2024

gumb0 Feb 27, 2024

chfast Feb 27, 2024

gumb0 Feb 27, 2024

gumb0 Feb 27, 2024

chfast Feb 28, 2024

chfast Feb 26, 2024

chfast Feb 26, 2024

chfast Feb 27, 2024

gumb0 Feb 27, 2024

gumb0 Feb 27, 2024

gumb0 Feb 27, 2024

gumb0 Feb 28, 2024

chfast Feb 28, 2024

test: Add some mising State Test export features #807

test: Add some mising State Test export features #807

Conversation

chfast commented Feb 2, 2024

codecov bot commented Feb 2, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Feb 2, 2024 •

edited

Loading