-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EIP-7610 (non-empty storage create collision) and upgrade execution-tests #816
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 98.50% 98.28% -0.23%
==========================================
Files 130 127 -3
Lines 15619 15574 -45
==========================================
- Hits 15386 15307 -79
- Misses 233 267 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6dd6bd6
to
af793ec
Compare
333d376
to
858f717
Compare
42e86ea
to
9fbb408
Compare
858f717
to
de11a0e
Compare
de11a0e
to
936bba3
Compare
@@ -268,14 +275,6 @@ evmc::Result Host::create(const evmc_message& msg) noexcept | |||
|
|||
new_acc->just_created = true; | |||
|
|||
// Clear the new account storage, but keep the access status (from tx access list). | |||
// This is only needed for tests and cannot happen in real networks. | |||
for (auto& [k, v] : new_acc->storage) [[unlikely]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the storage is empty now we don't have to do anything with it. This is really nice because this eliminates the only case for storage traversal in EVM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could replace with assertion, but not very important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not easy check because of the access list... so I'll pass.
This implements EIP-7610: Revert creation in case of non-empty storage. When a contract creation collides with an existing account it also reverts in case of the storage not being empty. https://eips.ethereum.org/EIPS/eip-7610
Also disable EIP tests for EIP-2537 because this is not implemented.
9720138
to
f538f9e
Compare
This implements EIP-7610: Revert creation in case of non-empty storage.
When a contract creation collides with an existing account it also reverts in case of the storage not being empty.
The ethereum/tests are upgraded to v13.3.