test: ExportableFixture for JSON tests exporting #821
Conversation
chfast
force-pushed
the
test/exportable
branch
from
ec6f96f
to
fbc09a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 113 114 +1
Lines 11155 11158 +3
=======================================
+ Hits 10930 10933 +3
Misses 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| class ExportableFixture : public testing::Test | ||
| { | ||
| protected: | ||
| std::unique_ptr<std::ostream> export_out; |
There was a problem hiding this comment.
This doesn't work, it has to be std::unique_ptr<std::ofstream> otherwise proper file stream destructor is not called and file is not written to disk.
There was a problem hiding this comment.
What a hell? Am I doing something wrong?
There was a problem hiding this comment.
Still not sure why it doesn't work. But this is fixed differently now because we also want to avoid creating empty files. So the file creation is left up to the concrete test suite.
I also added a cmake test that verifies an example file was created during export.
There was a problem hiding this comment.
Still not sure why it doesn't work
I'm also not sure anymore, becaue apparently destructor is indeed virtual 🤷♂️
There was a problem hiding this comment.
I was able to reproduce the same issue.
chfast
force-pushed
the
test/exportable
branch
from
fbc09a8
to
27f0910
Compare
Extract utils for JSON tests exporting to abstract `ExportableFixture`.
To follow the ExportableFixture file naming convention.
chfast
force-pushed
the
test/exportable
branch
from
27f0910
to
5de76a6
Compare
Extract utils for JSON tests exporting to abstract
ExportableFixture.