state: Fix failing code deployment in Frontier #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
==========================================
+ Coverage 97.98% 98.02% +0.04%
==========================================
Files 116 116
Lines 11370 11457 +87
==========================================
+ Hits 11141 11231 +90
+ Misses 229 226 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
state/fix_frontier_code_deployment
branch
from
0081c26
to
83e2efc
Compare
gumb0
reviewed
Feb 28, 2024
gumb0
reviewed
Feb 28, 2024
gumb0
reviewed
Feb 29, 2024
| const auto created = compute_create_address(To, pre.get(To).nonce); | ||
| expect.post[created].code = bytes{}; // code deployment failure creates empty account | ||
| expect.post[created].nonce = 0; | ||
| expect.post[created].storage[0x00_bytes32] = 0x01_bytes32; // storage stays |
There was a problem hiding this comment.
And this affects EIP-7610 nowadays :)
https://ethereum-magicians.org/t/eip-7610-revert-creation-in-case-of-non-empty-storage
chfast
force-pushed
the
state/fix_frontier_code_deployment
branch
from
83e2efc
to
a160ae3
Compare
gumb0
approved these changes
Mar 4, 2024
In Frontier when CREATE fails to deploy the code because of the deployment cost the creation behaves as it has been successful although the created account has empty code. Fix the CREATE instruction by returning the address of the created account instead of the null address. The gas refund is also applied as in the case of successful code deployment. Geth agrees with this but this situation probably never happened on Mainnet.
chfast
force-pushed
the
state/fix_frontier_code_deployment
branch
from
a160ae3
to
eb2cb4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Frontier when CREATE fails to deploy the code because of the deployment cost the creation behaves as it has been successful although the created account has empty code.
Fix the CREATE instruction by returning the address of the created account instead of the null address.
The gas refund is also applied as in the case of successful code deployment. Geth agrees with this but this situation probably never happened on Mainnet.