Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EXCHANGE from EIP-663 #839

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Implement EXCHANGE from EIP-663 #839

merged 1 commit into from
Mar 20, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Mar 18, 2024

@@ -0,0 +1,49 @@
// evmone: Fast Ethereum Virtual Machine implementation
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dividing line between this and the evm_... test still evades me.

My rationale was convenience mostly - this test here only tests basic cases, mostly to ensure different EVMs have the same understanding of the meaning of the arguments. The evm_... test is more manageable and as such contains more cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are not needed in this case unless you want to export them to JSON.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, my thinking was exactly - export to JSON

@pdobacz pdobacz requested a review from gumb0 March 18, 2024 15:49
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (9205d33) to head (e9cd4db).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
+ Coverage   97.97%   97.99%   +0.02%     
==========================================
  Files         119      121       +2     
  Lines       11930    12091     +161     
==========================================
+ Hits        11688    11849     +161     
  Misses        242      242              
Flag Coverage Δ
blockchaintests 61.20% <0.00%> (-0.36%) ⬇️
statetests 61.90% <37.50%> (-0.07%) ⬇️
statetests-silkpre 23.13% <1.94%> (-0.32%) ⬇️
unittests 96.57% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/advanced_instructions.cpp 100.00% <ø> (ø)
lib/evmone/baseline_instruction_table.cpp 100.00% <ø> (ø)
lib/evmone/eof.cpp 84.47% <100.00%> (+0.14%) ⬆️
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/eof_validation_stack_test.cpp 100.00% <100.00%> (ø)
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
test/unittests/evm_eip663_exchange_test.cpp 100.00% <100.00%> (ø)
test/unittests/instructions_test.cpp 89.58% <ø> (ø)
test/unittests/state_transition_eip663_test.cpp 100.00% <100.00%> (ø)
test/utils/bytecode.hpp 96.49% <100.00%> (+0.02%) ⬆️

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to the spec in the description.

@@ -0,0 +1,49 @@
// evmone: Fast Ethereum Virtual Machine implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are not needed in this case unless you want to export them to JSON.

@pdobacz pdobacz merged commit 7bd7596 into master Mar 20, 2024
25 checks passed
@pdobacz pdobacz deleted the exchange branch March 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement EXCHANGE (as part of EOF)
2 participants