-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EXCHANGE from EIP-663 #839
Conversation
@@ -0,0 +1,49 @@ | |||
// evmone: Fast Ethereum Virtual Machine implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dividing line between this and the evm_...
test still evades me.
My rationale was convenience mostly - this test here only tests basic cases, mostly to ensure different EVMs have the same understanding of the meaning of the arguments. The evm_...
test is more manageable and as such contains more cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are not needed in this case unless you want to export them to JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, my thinking was exactly - export to JSON
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 97.97% 97.99% +0.02%
==========================================
Files 119 121 +2
Lines 11930 12091 +161
==========================================
+ Hits 11688 11849 +161
Misses 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to the spec in the description.
@@ -0,0 +1,49 @@ | |||
// evmone: Fast Ethereum Virtual Machine implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are not needed in this case unless you want to export them to JSON.
Closes #774
spec in https://eips.ethereum.org/EIPS/eip-663 and https://github.com/ipsilon/eof/blob/main/spec/eof.md