Fix exported error messages for invalid tx tests

[pdobacz]

Addresses feedback from previous PR: #858 (comment)

[codecov]

Codecov Report

Attention: Patch coverage is 37.50000% with 30 lines in your changes are missing coverage. Please review.

Please upload report for BASE (master@633f696). Learn more about missing BASE report.

❗ Current head 4589219 differs from pull request most recent head 1516682

Please upload reports for the commit 1516682 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #886   +/-   ##
=========================================
  Coverage          ?   98.25%           
=========================================
  Files             ?      130           
  Lines             ?    15672           
  Branches          ?        0           
=========================================
  Hits              ?    15398           
  Misses            ?      274           
  Partials          ?        0           

Flag	Coverage Δ
ethereum-tests	27.90% <0.00%> (?)
ethereum-tests-silkpre	19.66% <0.00%> (?)
execution-spec-tests	19.00% <0.00%> (?)
unittests	94.11% <37.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
test/state/state.hpp	100.00% <ø> (ø)
test/unittests/state_transition.cpp	98.40% <100.00%> (ø)
test/state/state.cpp	91.45% <34.78%> (ø)

[pdobacz]

The missing messages PR'd to retesteth in ethereum/retesteth#226

[pdobacz]

Codecov is complaining about new lines not being covered, but from what I understand, covering them would require adding new state_transition_tx.test to cover invalid blob tx (among others). Should we be doing that?

Alternatively we can remove the never used entries from the get_tests_invalid_tx_message switch, leaving it to fail on assert(false). Maybe actually this is better, at the expense of tidiness of the switch. WDYT @gumb0 ?

[chfast]

You don't need to address missing coverage.

But please properly rebase (no merge commits) before merging.