Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TXCREATE and InitcodeTransaction to Osaka #889

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented May 13, 2024

The TXCREATE instruction and EOF InitcodeTransaction have been removed from the EIP-7620 in ethereum/EIPs#8522.

This update moves the implementation of these to the next revision: Osaka.

Requires ethereum/evmc#711

@gumb0 gumb0 added the EOF label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (642ebda) to head (52a55b9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   98.48%   98.50%   +0.01%     
==========================================
  Files         130      130              
  Lines       15625    15625              
==========================================
+ Hits        15389    15391       +2     
+ Misses        236      234       -2     
Flag Coverage Δ
ethereum-tests 27.95% <0.00%> (ø)
ethereum-tests-silkpre 19.69% <0.00%> (ø)
execution-spec-tests 19.06% <0.00%> (ø)
unittests 94.35% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/state/state.cpp 100.00% <100.00%> (ø)
...est/unittests/state_transition_eof_create_test.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@gumb0 gumb0 force-pushed the postpone-txcreate branch 3 times, most recently from 7ac7093 to c2568e2 Compare May 14, 2024 07:50
@chfast
Copy link
Member

chfast commented May 23, 2024

I meged the EVMC upgrade only in #897.

@gumb0 gumb0 force-pushed the postpone-txcreate branch from c2568e2 to c44ebd7 Compare May 24, 2024 10:10
@gumb0
Copy link
Member Author

gumb0 commented May 24, 2024

This is currently blocked on updating ethereum/tests

@chfast chfast force-pushed the postpone-txcreate branch from c44ebd7 to 52a55b9 Compare May 24, 2024 16:50
@chfast chfast changed the title Move TXCREATE to Osaka Move TXCREATE and InitcodeTransaction to Osaka May 24, 2024
@chfast chfast marked this pull request as ready for review May 24, 2024 16:57
@chfast chfast merged commit 7f65121 into master May 24, 2024
24 checks passed
@chfast chfast deleted the postpone-txcreate branch May 24, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants