EOF RETURNDATA* to pad on OOB read #909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #896, implements ipsilon/eof#90 / ethereum/EIPs#8617 the simplest way - by checking two first bytes of code on every instructions.
A better version would be to store the result in ExecutionState, and the best to use an entirely different instruction table in
dispatch
functions.Should we do the
ExecutionState
version right away now, or keep as is? Anyway, opening as draft until the EOF pr doesn't get merged (should be decided on the next eof impl call)