Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF RETURNDATA* to pad on OOB read #909

Merged
merged 3 commits into from
Jun 4, 2024
Merged

EOF RETURNDATA* to pad on OOB read #909

merged 3 commits into from
Jun 4, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented May 28, 2024

Closes #896, implements ipsilon/eof#90 / ethereum/EIPs#8617 the simplest way - by checking two first bytes of code on every instructions.

A better version would be to store the result in ExecutionState, and the best to use an entirely different instruction table in dispatch functions.

Should we do the ExecutionState version right away now, or keep as is? Anyway, opening as draft until the EOF pr doesn't get merged (should be decided on the next eof impl call)

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (df16c70) to head (f976b45).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   95.29%   95.33%   +0.03%     
==========================================
  Files         138      138              
  Lines       15485    15615     +130     
==========================================
+ Hits        14757    14887     +130     
  Misses        728      728              
Flag Coverage Δ
ethereum_tests 26.77% <10.55%> (-0.18%) ⬇️
ethereum_tests_silkpre 18.53% <9.31%> (-0.10%) ⬇️
execution_spec_tests 18.07% <7.14%> (-0.11%) ⬇️
unittests 90.38% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/evmone/instructions.hpp 100.00% <100.00%> (ø)
test/unittests/evm_eof_calls_test.cpp 100.00% <100.00%> (ø)

@pdobacz pdobacz marked this pull request as ready for review June 3, 2024 08:08
@pdobacz pdobacz requested a review from chfast June 3, 2024 09:30
@pdobacz pdobacz merged commit 5a19003 into master Jun 4, 2024
25 checks passed
@pdobacz pdobacz deleted the eof-returndatacopy branch June 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EOF - tentative impl of eof#90 (RETURNDATA*)
2 participants